Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Fix: constraint on num_all_txs_acc' is wrong #790

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fix: constraint on num_all_txs_acc' is wrong #790

merged 1 commit into from
Aug 18, 2023

Conversation

kunxian-xia
Copy link

Description

This is a continuation of #789.

num_all_txs_acc' = num_all_txs_acc + (is_l1_msg ? queue_index' - total_l1_popped_before' + 1 : 1).

Issue Link

chunk_8540

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@silathdiir silathdiir merged commit 750169c into develop Aug 18, 2023
@silathdiir silathdiir deleted the fix/num_all_txs_acc branch August 18, 2023 04:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@icemelon icemelon icemelon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunxian-xia @icemelon @silathdiir