This repository was archived by the owner on Apr 18, 2025. It is now read-only.
fix finding 24 #656
Closed
fix finding 24 #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
roynalnaruto
reviewed
Aug 9, 2023
| vec![(q_enable * cum_num_txs, u16_table)] | ||
| }); | ||
|
|
||
| for diff in tx_id_cmp_cum_num_txs.lt_chip.config().diff { |
There was a problem hiding this comment.
We want the overall diff to be a byte, right?
Here you've constrained that each diff cell is a byte, which is already constrained within the LtGadget here:
https://github.com/scroll-tech/zkevm-circuits/blob/develop/gadgets/src/less_than.rs#L97-L105
There was a problem hiding this comment.
We add this because the range checks of each diff cell are not there when the auditing is done. Yeah, we should remove these redundant checks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix finding 24 in Zellic / Kalos Audit Report.
Type of change