Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Fix zellic & kalos finding 28 #624

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fix zellic & kalos finding 28 #624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47648ea
fix finding 28
kunxian-xia Jul 13, 2023
6b9bae2
Merge branch 'fix/tx-audit-wave' into fix/tx-zellic-finding28
roynalnaruto Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions zkevm-circuits/src/tx_circuit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ impl<F: Field> SubCircuitConfig<F> for TxCircuitConfig<F> {

cb.require_equal(
"is_calldata",
tag_bits.value_equals(CallData, Rotation::cur())(meta),
is_data(meta),
meta.query_advice(is_calldata, Rotation::cur()),
);

Expand All @@ -476,7 +476,7 @@ impl<F: Field> SubCircuitConfig<F> for TxCircuitConfig<F> {

cb.require_equal(
"is_caller_address",
tag_bits.value_equals(CallerAddress, Rotation::cur())(meta),
is_caller_addr(meta),
meta.query_advice(is_caller_address, Rotation::cur()),
);

Expand All @@ -488,7 +488,7 @@ impl<F: Field> SubCircuitConfig<F> for TxCircuitConfig<F> {

cb.require_equal(
"is_chain_id",
tag_bits.value_equals(ChainID, Rotation::cur())(meta),
is_chain_id_expr(meta),
meta.query_advice(is_chain_id, Rotation::cur()),
);

Expand Down Expand Up @@ -1165,7 +1165,7 @@ impl<F: Field> TxCircuitConfig<F> {
is_none,
]
.into_iter()
.zip(rlp_table.table_exprs(meta).into_iter()) // tag_length_eq_one is the 6th column in rlp table
.zip(rlp_table.table_exprs(meta).into_iter())
.map(|(arg, table)| (enable.clone() * arg, table))
.collect()
});
Expand Down Expand Up @@ -1284,7 +1284,7 @@ impl<F: Field> TxCircuitConfig<F> {
});
}

/// Load ECDSA RangeChip table.
/// Load u16 range table.
pub fn load_aux_tables(&self, layouter: &mut impl Layouter<F>) -> Result<(), Error> {
layouter.assign_table(
|| "u16 fixed table",
Expand Down