This repository was archived by the owner on Apr 18, 2025. It is now read-only.
scroll-dev-0521 #158
Closed
scroll-dev-0521 #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispc
commented
May 23, 2022
•
lispc
commented
- use dummy implementation to support any traces in evm circuit
- make selector offset fixed in evm circuit
- fix a bug in end_tx
- support eip2930 (skip some checks rather than implement..)
DreamWuGit
reviewed
May 25, 2022
|
TODO: use meta.minimum_rows() to decide pad_to automatically |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.