This repository was archived by the owner on Apr 18, 2025. It is now read-only.
forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 390
update L1 data fee for curie #1293
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark ready for ci checking purpose |
lispc
reviewed
May 29, 2024
lispc
reviewed
May 29, 2024
lispc
reviewed
May 29, 2024
lispc
reviewed
May 29, 2024
/// Committed value of L1 base fee | ||
#[cfg(feature = "l1_fee_curie")] | ||
/// Current value of L1 blob base fee | ||
l1_blob_basefee_word: U64Word<F>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to check with peter whether they really in range u64.
lispc
reviewed
May 29, 2024
if scroll-prover test passes, i will merge this. But later i think we should add some unit tests in repo. |
lispc
reviewed
May 29, 2024
lispc
reviewed
May 29, 2024
wow, test have passed!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
l1_fee_curie
switch for curie forkIssue Link
[link issue here]
Type of change