Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

update L1 data fee for curie #1293

Merged
merged 40 commits into from
May 30, 2024
Merged

update L1 data fee for curie #1293

merged 40 commits into from
May 30, 2024

Conversation

DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented May 27, 2024

Description

  • add feature l1_fee_curie switch for curie fork
  • buss mapping update transaction to get new fields
  • update circuit(L1fee gadget) for new fields operations and apply new formula
    • begin_tx
    • end_tx
    • TxL1FeeGadget
  • testing stuffs

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@DreamWuGit
Copy link
Author

mark ready for ci checking purpose

@DreamWuGit DreamWuGit marked this pull request as ready for review May 28, 2024 09:25
/// Committed value of L1 base fee
#[cfg(feature = "l1_fee_curie")]
/// Current value of L1 blob base fee
l1_blob_basefee_word: U64Word<F>,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check with peter whether they really in range u64.

@lispc
Copy link

lispc commented May 29, 2024

if scroll-prover test passes, i will merge this. But later i think we should add some unit tests in repo.

@DreamWuGit
Copy link
Author

if scroll-prover test passes, i will merge this. But later i think we should add some unit tests in repo.

wow, test have passed!!

@lispc lispc marked this pull request as ready for review May 29, 2024 14:26
DreamWuGit and others added 4 commits May 30, 2024 09:57
* fix constraint for remainder in l1fee

Signed-off-by: noelwei <fan@scroll.io>

* fmt

Signed-off-by: noelwei <fan@scroll.io>

---------

Signed-off-by: noelwei <fan@scroll.io>
Co-authored-by: DreamWuGit <wwuwwei@126.com>
@lispc lispc merged commit 6368e07 into develop May 30, 2024
@lispc lispc deleted the l1fee_curie branch May 30, 2024 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants