Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

fix audit: constrain tx_l1_fee gadget #1151

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix audit: constrain tx_l1_fee gadget #1151

merged 3 commits into from
Apr 22, 2024

Conversation

DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented Mar 18, 2024

Description

audit item: The tx_l1_fee gadget might be under constrained,
fix by adding constrain l1_fee_word zero if it is l1 msg tx

split single PR for each audit item from #1147

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@lispc lispc merged commit cfcb073 into develop Apr 22, 2024
@lispc lispc deleted the audit_tx_l1_fee_gadget branch April 22, 2024 07:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants