Skip to content

fix(relayer): fix rolling hash computation #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2025
Merged

Conversation

jonastheis
Copy link
Contributor

@jonastheis jonastheis commented Mar 13, 2025

Purpose or design rationale of this PR

Based on scroll-tech/da-codec#48 all message hashes were incorrect and thus also the rolling hashes passed to the prover which lead to proving failure.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores

    • Updated a key dependency to the latest version for improved performance and reliability.
    • Updated the version tag for the application.
  • Refactor

    • Streamlined the transaction data conversion process by centralizing logic and removing redundant components.

Copy link

coderabbitai bot commented Mar 13, 2025

Walkthrough

This pull request updates the version of the github.com/scroll-tech/da-codec dependency in the rollup/go.mod file and refactors transaction data conversion in rollup/internal/controller/watcher/l2_watcher.go. The obsolete function txsToTxsData is removed and its functionality is replaced by a call to encoding.TxsToTxsData. Unused imports associated with the removed function have also been cleaned up. Additionally, the version tag in common/version/version.go is updated.

Changes

File(s) Change Summary
rollup/go.mod Updated dependency version for github.com/scroll-tech/da-codec from v0.1.3-0.20250310095435-012aaee6b435 to v0.1.3-0.20250313030021-a8341d04bc4e.
rollup/internal/controller/watcher/l2_watcher.go Removed txsToTxsData function; updated getAndStoreBlocks to call encoding.TxsToTxsData; removed unused imports (hexutil, gethTypes).
common/version/version.go Updated version tag from v4.4.97 to v4.4.98.

Sequence Diagram(s)

sequenceDiagram
    participant Watcher as L2 Watcher
    participant Encoding as Encoding Package
    Watcher->>Encoding: Call TxsToTxsData(block.Transactions())
    Encoding-->>Watcher: Returns converted transaction data
Loading

Possibly related PRs

Suggested reviewers

  • georgehao
  • colinlyguo
  • Thegaram

Poem

I'm a rabbit hopping with delight,
In the code garden, changes shine so bright.
Out with old, in with the new,
Function revamped, and imports few.
Leaping high with dependency cheer,
Coding hops bring joy near!
(_/) 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69f2196 and 3a981c9.

📒 Files selected for processing (1)
  • common/version/version.go (1 hunks)
🔇 Additional comments (1)
common/version/version.go (1)

8-8: Version increment aligns with the bug fix

The version has been correctly incremented from v4.4.97 to v4.4.98, which aligns with the PR's purpose of fixing the rolling hash computation issue. This minor version bump follows semantic versioning principles for non-breaking bug fixes.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

georgehao
georgehao previously approved these changes Mar 13, 2025
@jonastheis jonastheis added the bump-version Bump the version tag for deployment label Mar 13, 2025
@jonastheis jonastheis merged commit 0a1868c into develop Mar 13, 2025
1 check passed
@jonastheis jonastheis deleted the fix/l1-message-hash-bug branch March 13, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants