Skip to content

feat: upgrade to euclid-enabled l2geth #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Conversation

omerfirmak
Copy link
Contributor

@omerfirmak omerfirmak commented Mar 10, 2025

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Summary by CodeRabbit

  • Chores
    • Upgraded several key dependency versions to ensure increased stability and access to the latest updates, including github.com/scroll-tech/go-ethereum and github.com/scroll-tech/da-codec.
    • Adjusted build configurations to align with these dependency revisions.
    • Incremented the application version from v4.4.91 to v4.4.92.

@omerfirmak omerfirmak added the bump-version Bump the version tag for deployment label Mar 10, 2025
Copy link

coderabbitai bot commented Mar 10, 2025

Walkthrough

This pull request updates several dependency version tags and identifiers across the project. The Makefile now sets the L2GETH_TAG to scroll-v5.8.23 rather than the previous version. Multiple go.mod files have been updated to reference newer commit hashes for both the go-ethereum and da-codec dependencies. Additionally, the version tag in common/version/version.go has been incremented from "v4.4.91" to "v4.4.92". These changes ensure that the project uses the latest revisions without altering any existing functionality or command flows.

Changes

File(s) Change Summary
Makefile Updated L2GETH_TAG from scroll-v5.8.20 to scroll-v5.8.23.
common/go.mod, coordinator/go.mod, database/go.mod, rollup/go.mod, tests/integration-test/go.mod Updated dependency versions for github.com/scroll-tech/go-ethereum and github.com/scroll-tech/da-codec to newer commits.
bridge-history-api/go.mod Updated github.com/scroll-tech/go-ethereum dependency version from v1.10.14-0.20250304112538-3c454e7101a3 to v1.10.14-0.20250305084331-57148478e950 with a hotfix note.
common/version/version.go Updated version tag from "v4.4.91" to "v4.4.92".

Possibly related PRs

Suggested reviewers

  • georgehao
  • Thegaram

Poem

I'm a little rabbit, hopping with glee,
Code fields shine brighter now for me.
New tags and versions, crisp and new,
Dependencies updated, steady and true.
With a quick nibble of code and a joyful cheer,
I celebrate this update—carrot emoji here! 🥕

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 golangci-lint (1.62.2)

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd""
level=error msg="Running error: can't run linter goanalysis_metalinter\nbuildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e89423 and 62b9e75.

⛔ Files ignored due to path filters (1)
  • bridge-history-api/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • bridge-history-api/go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: test
  • GitHub Check: tests
  • GitHub Check: tests
  • GitHub Check: tests
  • GitHub Check: tests
  • GitHub Check: check
  • GitHub Check: check
  • GitHub Check: check
  • GitHub Check: check
  • GitHub Check: tests
  • GitHub Check: check
🔇 Additional comments (1)
bridge-history-api/go.mod (1)

13-13: Dependency Version Hotfix Update Verification

The dependency version for github.com/scroll-tech/go-ethereum has been updated to v1.10.14-0.20250305084331-57148478e950 with a note that it’s a hotfix for a header hash incompatibility issue. Please ensure that:

  • This update is fully tested across modules that depend on this dependency.
  • The version update is consistent with those in other modules of the project.
  • Adequate documentation or commit history notes are maintained given the cautionary comment.

Overall, the change looks appropriate for a hotfix update.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

georgehao
georgehao previously approved these changes Mar 10, 2025
colinlyguo
colinlyguo previously approved these changes Mar 10, 2025
georgehao
georgehao previously approved these changes Mar 10, 2025
colinlyguo
colinlyguo previously approved these changes Mar 10, 2025
@colinlyguo colinlyguo dismissed stale reviews from georgehao and themself via 62b9e75 March 10, 2025 10:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.14%. Comparing base (7a386ad) to head (62b9e75).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1612   +/-   ##
========================================
  Coverage    42.14%   42.14%           
========================================
  Files          222      222           
  Lines        17739    17739           
========================================
  Hits          7476     7476           
  Misses        9555     9555           
  Partials       708      708           
Flag Coverage Δ
bridge-history-api 8.06% <ø> (ø)
common 28.77% <ø> (ø)
coordinator 34.31% <ø> (ø)
database 42.05% <ø> (ø)
rollup 54.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@omerfirmak omerfirmak merged commit 056ebdc into develop Mar 10, 2025
18 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/up-geth branch March 10, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants