fix(coordinator): fix not-compatible-prover errors counting towards number of attempts (#1619)

Author: omerfirmak

coordinator/internal/logic/provertask/batch_prover_task.go

@@ -135,8 +135,6 @@ func (bp *BatchProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinato
 		return nil, nil
 	}
 
-	log.Info("start batch proof generation session", "task_id", batchTask.Hash, "public key", taskCtx.PublicKey, "prover name", taskCtx.ProverName)
-
 	hardForkName, getHardForkErr := bp.hardForkName(ctx, batchTask)
 	if getHardForkErr != nil {
 		bp.recoverActiveAttempts(ctx, batchTask)
@@ -146,13 +144,14 @@ func (bp *BatchProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinato
 
 	if _, ok := taskCtx.HardForkNames[hardForkName]; !ok {
 		bp.recoverActiveAttempts(ctx, batchTask)
-		log.Error("incompatible prover version",
+		log.Debug("incompatible prover version",
 			"requisite hard fork name", hardForkName,
 			"prover hard fork name", taskCtx.HardForkNames,
 			"task_id", batchTask.Hash)
-		return nil, ErrCoordinatorInternalFailure
+		return nil, nil
 	}
 
+	log.Info("start batch proof generation session", "task_id", batchTask.Hash, "public key", taskCtx.PublicKey, "prover name", taskCtx.ProverName)
 	proverTask := orm.ProverTask{
 		TaskID:          batchTask.Hash,
 		ProverPublicKey: taskCtx.PublicKey,

coordinator/internal/logic/provertask/bundle_prover_task.go

@@ -135,8 +135,6 @@ func (bp *BundleProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinat
 		return nil, nil
 	}
 
-	log.Info("start bundle proof generation session", "task index", bundleTask.Index, "public key", taskCtx.PublicKey, "prover name", taskCtx.ProverName)
-
 	hardForkName, getHardForkErr := bp.hardForkName(ctx, bundleTask)
 	if getHardForkErr != nil {
 		bp.recoverActiveAttempts(ctx, bundleTask)
@@ -146,13 +144,14 @@ func (bp *BundleProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinat
 
 	if _, ok := taskCtx.HardForkNames[hardForkName]; !ok {
 		bp.recoverActiveAttempts(ctx, bundleTask)
-		log.Error("incompatible prover version",
+		log.Debug("incompatible prover version",
 			"requisite hard fork name", hardForkName,
 			"prover hard fork name", taskCtx.HardForkNames,
 			"task_id", bundleTask.Hash)
-		return nil, ErrCoordinatorInternalFailure
+		return nil, nil
 	}
 
+	log.Info("start bundle proof generation session", "task index", bundleTask.Index, "public key", taskCtx.PublicKey, "prover name", taskCtx.ProverName)
 	proverTask := orm.ProverTask{
 		TaskID:          bundleTask.Hash,
 		ProverPublicKey: taskCtx.PublicKey,

coordinator/internal/logic/provertask/chunk_prover_task.go

@@ -133,8 +133,6 @@ func (cp *ChunkProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinato
 		return nil, nil
 	}
 
-	log.Info("start chunk generation session", "task_id", chunkTask.Hash, "public key", taskCtx.PublicKey, "prover name", taskCtx.ProverName)
-
 	hardForkName, getHardForkErr := cp.hardForkName(ctx, chunkTask)
 	if getHardForkErr != nil {
 		cp.recoverActiveAttempts(ctx, chunkTask)
@@ -144,13 +142,14 @@ func (cp *ChunkProverTask) Assign(ctx *gin.Context, getTaskParameter *coordinato
 
 	if _, ok := taskCtx.HardForkNames[hardForkName]; !ok {
 		cp.recoverActiveAttempts(ctx, chunkTask)
-		log.Error("incompatible prover version",
+		log.Debug("incompatible prover version",
 			"requisite hard fork name", hardForkName,
 			"prover hard fork name", taskCtx.HardForkNames,
 			"task_id", chunkTask.Hash)
-		return nil, ErrCoordinatorInternalFailure
+		return nil, nil
 	}
 
+	log.Info("start chunk generation session", "task_id", chunkTask.Hash, "public key", taskCtx.PublicKey, "prover name", taskCtx.ProverName)
 	proverTask := orm.ProverTask{
 		TaskID:          chunkTask.Hash,
 		ProverPublicKey: taskCtx.PublicKey,