Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] use lookup tables for u16 assignment #2

Merged
merged 4 commits into from
May 24, 2023
Merged

[feat] use lookup tables for u16 assignment #2

merged 4 commits into from
May 24, 2023

Conversation

zhenfeizhang
Copy link

@zhenfeizhang zhenfeizhang commented May 22, 2023 •
edited
Loading

Without "bn256-table"

z@ubuntu:~/Desktop/0220/halo2curves$ cargo test --release bench_fr_from_u16 --features=print-trace  -- --nocapture 

Start:   generate 1000000 Bn256 scalar field elements
End:     generate 1000000 Bn256 scalar field elements ..............................38.108ms

Start:   generate 10000000 Bn256 scalar field elements
End:     generate 10000000 Bn256 scalar field elements .............................268.232ms

With "bn256-table"

z@ubuntu:~/Desktop/0220/halo2curves$ cargo test --release bench_fr_from_u16 --features=print-trace,bn256-table  -- --nocapture

Start:   generate 1000000 Bn256 scalar field elements
End:     generate 1000000 Bn256 scalar field elements ..............................12.365ms

Start:   generate 10000000 Bn256 scalar field elements
End:     generate 10000000 Bn256 scalar field elements .............................84.353ms

@zhenfeizhang zhenfeizhang merged commit c763162 into 0.3.1-derive-serde May 24, 2023
zhenfeizhang added a commit that referenced this pull request May 25, 2023
@zhenfeizhang
Revert "[feat] use lookup tables for u16 assignment (#2)"
aca5189 
This reverts commit c763162.
lightsing pushed a commit to lightsing/halo2curves that referenced this pull request Jan 30, 2024
@mratsim @AlekseiVambol
Fast modular inverse - 9.4x acceleration (privacy-scaling-exploration…
a835096 
…s#83)

* Bernstein yang modular multiplicative inverter (scroll-tech#2)

* rename similar to privacy-scaling-explorations#95

---------

Co-authored-by: Aleksei Vambol <77882392+AlekseiVambol@users.noreply.github.com>
z2trillion pushed a commit that referenced this pull request Feb 22, 2024
@han0110
Merge pull request #2 from han0110/fix/impl-fq2-to-repr
f75ed26 
Implement `ff::PrimeField::to_repr` for `bn256::Fq2`
Velaciela pushed a commit that referenced this pull request Aug 14, 2024
@mratsim @AlekseiVambol @Velaciela
Fast modular inverse - 9.4x acceleration (privacy-scaling-exploration…
6ae1ddc 
…s#83)

* Bernstein yang modular multiplicative inverter (#2)

* rename similar to privacy-scaling-explorations#95

---------

Co-authored-by: Aleksei Vambol <77882392+AlekseiVambol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhenfeizhang