Skip to content

sync rollup_sync_service fixes #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2024
Merged

sync rollup_sync_service fixes #860

merged 3 commits into from
Jun 26, 2024

Conversation

0xmountaintop
Copy link

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

colinlyguo and others added 3 commits June 26, 2024 17:24
@colinlyguo @Thegaram @0xmountaintop
feat(rollup): add fallback if TransactionByHash fails in getting comm…
02b9229 
…itBatch calldata (#601)

* feat(rollup): add fallback if TransactionByHash fails in getting commitBatch calldata

* Update rollup/rollup_sync_service/rollup_sync_service.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* change log.Warn to log.Debug

---------

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
@colinlyguo @0xmountaintop
fix(rollup sync service): remove syscall.Kill (#636)
f9a9592 
* fix(rollup sync service): remove syscall.Kill

* bump version
@colinlyguo @0xmountaintop
fix(api-backend): disable finalized tag when rollup verify is disabled (
ecb8a92 
#722)
@0xmountaintop 0xmountaintop force-pushed the syncUpstream/rollup_sync_service_2 branch from 90ef69d to ecb8a92 Compare June 26, 2024 09:25
@0xmountaintop 0xmountaintop changed the title Sync rollup_sync_service changes sync rollup_sync_service fixes Jun 26, 2024
@0xmountaintop 0xmountaintop marked this pull request as ready for review June 26, 2024 09:37
@0xmountaintop 0xmountaintop merged commit a83c05c into syncUpstream/active Jun 26, 2024
5 of 6 checks passed
@0xmountaintop 0xmountaintop deleted the syncUpstream/rollup_sync_service_2 branch June 26, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmountaintop @colinlyguo