Skip to content

Chore: upgrade libzkp v0.10.6 #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Chore: upgrade libzkp v0.10.6 #816

merged 2 commits into from
Jun 11, 2024

Conversation

lispc
Copy link

@lispc lispc commented Jun 11, 2024

1. Purpose or design rationale of this PR

At the time between signer curie hardfork and ccc upgraded to v0.11, this PR will reject txs with BASEFEE/TLOAD/TSTORE/MCOPY with err msg like

assertion `left == right` failed left: None right: Some(InvalidOpcode(INVALID(92)))

to prevent any inconsistency between sequencer and ccc.

Details: original commit: scroll-tech/zkevm-circuits@aabc96b#diff-1e6d053f6514ddc64497b6a584b3543a639730560b44b5fdf47a2c6b58b2ecd7R1626
When ccc thinks an opcode is invalid, it will require l2geth also treat the opcode as invalid.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc lispc marked this pull request as ready for review June 11, 2024 04:01
@Thegaram Thegaram requested review from Thegaram and colinlyguo June 11, 2024 07:47
@Thegaram Thegaram merged commit 16cbc9a into develop Jun 11, 2024
@Thegaram Thegaram deleted the chore/libzkp-v0.10.6 branch June 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants