Skip to content

fix(rollup-sync-service): remove syscall.Kill #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Feb 20, 2024

1. Purpose or design rationale of this PR

Currently, the code fails to compile on Windows:

rollup\rollup_sync_service\rollup_sync_service.go:398:11: undefined: syscall.Kill

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@colinlyguo colinlyguo requested a review from Thegaram February 20, 2024 06:49
Thegaram
Thegaram previously approved these changes Feb 20, 2024
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's also bump version

@colinlyguo
Copy link
Member Author

Tested with:

  1. successfully syncing:
INFO [02-20|16:24:58.605] finalized batch progress                 batch index=1100 finalized l2 block height=127,687
INFO [02-20|16:25:00.530] Imported new chain segment               blocks=327  txs=1145 mgas=155.390 elapsed=8.025s    mgasps=19.363  number=128,644 hash=a263a6..238471 age=4mo3d22h dirty=0.00B
INFO [02-20|16:25:08.569] Imported new chain segment               blocks=303  txs=1169 mgas=158.100 elapsed=8.039s    mgasps=19.665  number=128,947 hash=0b00a8..7d2e6d age=4mo3d22h dirty=0.00B
INFO [02-20|16:25:16.592] Imported new chain segment               blocks=268  txs=1174 mgas=156.204 elapsed=8.022s    mgasps=19.471  number=129,215 hash=76a132..438f50 age=4mo3d21h dirty=0.00B
INFO [02-20|16:25:24.594] Imported new chain segment               blocks=298  txs=1215 mgas=144.641 elapsed=8.002s    mgasps=18.074  number=129,513 hash=4ce748..9cde67 age=4mo3d21h dirty=0.00B
INFO [02-20|16:25:29.682] Imported new chain segment               blocks=180  txs=742  mgas=100.621 elapsed=5.088s    mgasps=19.776  number=129,693 hash=ba9d1f..6924cb age=4mo3d21h dirty=0.00B
  1. gracefully shutdown:
ERROR[02-20|16:33:50.443] State root mismatch                      batch index=1115 start block=128,662 end block=128,737 parent batch hash=0x938c7dc6139374cde779da104427374169edeac2cdc24e7d6f0251089e26427f l1 finalized state root=0x1cb2815011e57ef7fd23b63701a480d7c88c764e045aa4680118e28e858fa4cf l2 state root=0x1cb2815011e57ef7fd23b63701a480d7c88c764e045aa4680118e28e858fa4cf
INFO [02-20|16:33:50.443] HTTP server stopped                      endpoint=[::]:8545
INFO [02-20|16:33:50.443] IPC endpoint closed                      url=/Users/colin/Desktop/scroll_git/go-ethereum/l2geth-datadir/geth.ipc
WARN [02-20|16:33:50.487] Synchronisation failed, dropping peer    peer=667baf76d41997a74829e32e9942c2e907137ffe78a9e1efd8adca9e3cc0b559 err="retrieved hash chain is invalid: syncing canceled (requested)"
INFO [02-20|16:33:50.487] Ethereum protocol stopped 
INFO [02-20|16:33:50.487] Transaction pool stopped 
INFO [02-20|16:33:50.487] Stopping sync service 
INFO [02-20|16:33:50.487] Stopping rollup event sync background service 
INFO [02-20|16:33:50.528] Writing clean trie cache to disk         path=/Users/colin/Desktop/scroll_git/go-ethereum/l2geth-datadir/geth/triecache threads=12
INFO [02-20|16:33:50.960] Persisted the clean trie cache           path=/Users/colin/Desktop/scroll_git/go-ethereum/l2geth-datadir/geth/triecache elapsed=431.717ms
INFO [02-20|16:33:50.960] Blockchain stopped

@colinlyguo
Copy link
Member Author

colinlyguo commented Feb 20, 2024

The previous shutdown logs:

ERROR[02-20|16:38:49.971] State root mismatch                      batch index=1115 start block=128,662 end block=128,737 parent batch hash=0x938c7dc6139374cde779da104427374169edeac2cdc24e7d6f0251089e26427f l1 finalized state root=0x1cb2815011e57ef7fd23b63701a480d7c88c764e045aa4680118e28e858fa4cf l2 state root=0x1cb2815011e57ef7fd23b63701a480d7c88c764e045aa4680118e28e858fa4cf
ERROR[02-20|16:38:49.971] failed to parse and update rollup event logs err="fatal: validateBatch failed: finalize event: &{1115 0xdd2a5a5dc71c2c8fbcd024822737a16d017af9ccc0f06c687509db328fc22fbf 0x1cb2815011e57ef7fd23b63701a480d7c88c764e045aa4680118e28e858fa4cf 0x273fd5cee059755dbcb0fc37a46c48adf634779bfc0e973e6de177eb441c6e85}, err: withdraw root mismatch"
INFO [02-20|16:38:49.971] Got interrupt, shutting down... 
INFO [02-20|16:38:49.972] HTTP server stopped                      endpoint=[::]:8545
INFO [02-20|16:38:49.972] IPC endpoint closed                      url=/Users/colin/Desktop/scroll_git/go-ethereum/l2geth-datadir/geth.ipc
WARN [02-20|16:38:49.991] Synchronisation failed, dropping peer    peer=63a4b4eba5b1124271bd3820e899e32adb2bfeb1f75946ece42918087e4eab85 err="retrieved hash chain is invalid: syncing canceled (requested)"
INFO [02-20|16:38:49.991] Ethereum protocol stopped 
INFO [02-20|16:38:49.991] Transaction pool stopped 
INFO [02-20|16:38:49.991] Stopping sync service 
INFO [02-20|16:38:49.991] Stopping rollup event sync background service 
INFO [02-20|16:38:50.011] Writing clean trie cache to disk         path=/Users/colin/Desktop/scroll_git/go-ethereum/l2geth-datadir/geth/triecache threads=12
INFO [02-20|16:38:50.479] Persisted the clean trie cache           path=/Users/colin/Desktop/scroll_git/go-ethereum/l2geth-datadir/geth/triecache elapsed=467.615ms
INFO [02-20|16:38:50.479] Blockchain stopped

so the shutdown procedure does the same thing.

@0xmountaintop 0xmountaintop merged commit 483949b into develop Feb 21, 2024
@0xmountaintop 0xmountaintop deleted the fix-remove-syscall-Kill branch February 21, 2024 08:57
@colinlyguo colinlyguo changed the title fix(rollup sync service): remove syscall.Kill fix(rollup-sync-service): remove syscall.Kill May 24, 2024
0xmountaintop pushed a commit that referenced this pull request Jun 26, 2024
* fix(rollup sync service): remove syscall.Kill

* bump version
0xmountaintop added a commit that referenced this pull request Jun 26, 2024
* feat(rollup): add fallback if TransactionByHash fails in getting commitBatch calldata (#601)

* feat(rollup): add fallback if TransactionByHash fails in getting commitBatch calldata

* Update rollup/rollup_sync_service/rollup_sync_service.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* change log.Warn to log.Debug

---------

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* fix(rollup sync service): remove syscall.Kill (#636)

* fix(rollup sync service): remove syscall.Kill

* bump version

* fix(api-backend): disable finalized tag when rollup verify is disabled (#722)

---------

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants