feat(rollup): add fallback if TransactionByHash fails in getting commitBatch calldata #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
added
bug
colinlyguo
requested review from
georgehao,
0xmountaintop,
NazariiDenha and
Thegaram
Thegaram
previously approved these changes
Dec 15, 2023
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
NazariiDenha
approved these changes
Dec 15, 2023
georgehao
approved these changes
Dec 16, 2023
Thegaram
approved these changes
Dec 18, 2023
Thegaram
deleted the
feat-add-fallback-if-rollup-sync-service-get-tx-by-hash-failed
branch
0xmountaintop
pushed a commit
that referenced
this pull request
Jun 26, 2024
…itBatch calldata (#601) * feat(rollup): add fallback if TransactionByHash fails in getting commitBatch calldata * Update rollup/rollup_sync_service/rollup_sync_service.go Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * change log.Warn to log.Debug --------- Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
0xmountaintop
added a commit
that referenced
this pull request
Jun 26, 2024
* feat(rollup): add fallback if TransactionByHash fails in getting commitBatch calldata (#601) * feat(rollup): add fallback if TransactionByHash fails in getting commitBatch calldata * Update rollup/rollup_sync_service/rollup_sync_service.go Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * change log.Warn to log.Debug --------- Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * fix(rollup sync service): remove syscall.Kill (#636) * fix(rollup sync service): remove syscall.Kill * bump version * fix(api-backend): disable finalized tag when rollup verify is disabled (#722) --------- Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
The transaction indexing of a geth node is controlled by
--txlookuplimitflag, which indicates the number of recent blocks to maintain transactions index, thus in some cases, the l2geth node cannot successfully fetch old transactions to get commitBatch's calldata. To solve this issue, this PR:TransactionByHashfails in gettingcommitBatchcalldata.Related issues and discussions:
TransactionByHash returns null
TransactionReceipt returns null
Local test (you may need to tweak some code to go into fallback path):
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?