forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 282
feat: add system config consensus to deprecate clique #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
b68dcb7
feat: add system config consensus to deprecate poa
yiweichi 8e4deb1
fix: check extra field lens
yiweichi a77524f
Finish implementation with one signer only
ranchalp 4047f24
Implement unit tests
ranchalp b68d2d6
Only check signature if block not requested
ranchalp ad96fa4
Remove Extra from rlp encoding (and hashing)
ranchalp ec2e3d0
Implement UpgradableEngine as middleware for Clique/SystemContract
ranchalp 20185f2
Use isEuclid, add json tag to Requested, make go idiomatic
ranchalp 4d00f42
Changes post integration test
ranchalp 9d8a128
Merge branch 'develop' into feat-system-config-consensus
ranchalp 80e06b8
Remove comment
ranchalp d4c725e
Address comments
ranchalp 8f961e7
Merge
ranchalp ebd8e61
New field BlockSignature (not used in hashing/JSON)
ranchalp c3f5b46
Enforce .Extra to be an empty slice
ranchalp 3190585
replace header.Requested for header.IsNewBlock
ranchalp 38135a3
mark new block as IsNewBlock
ranchalp d59e79b
Make new RLP optional fields always default for legacy/reth compatibi…
ranchalp b077f71
Placing new fields as last non-zero rlp:optional values used by Scroll
ranchalp 6b2a63b
Penalize nodes that send non-zero Euclid V2 header field values
ranchalp 3fa378d
Bring back .Requested to downloader instead of .IsNewBlock
ranchalp 6638057
Replace IsNewBlock for Requested
ranchalp cd6344d
Address comments
ranchalp f6bcdd0
merge
ranchalp 9ca7498
Merge branch 'develop' into feat-system-config-consensus
ranchalp 80eba61
prevent timing issues in tests
jonastheis b2fb9a2
fix ci
jonastheis 396db64
chore: auto version bump [bot]
jonastheis cc5c7dc
Update consensus/system_contract/consensus.go
ranchalp e70acc6
Merge branch 'develop' into feat-system-config-consensus
ranchalp b914e00
chore: auto version bump [bot]
ranchalp 0b00789
Update consensus/system_contract/consensus.go
ranchalp d1e4790
Remove whitespaces and merge version number
ranchalp 3839bf7
chore: auto version bump [bot]
ranchalp 3c2347e
validate that the read address from L1 is not empty and improved erro…
jonastheis 07559cb
Fix indentation issue
ranchalp 83bf259
Fix test
ranchalp 3151105
goimports fix
ranchalp 297186b
goimports
Thegaram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package system_contract | ||
|
||
import ( | ||
"github.com/scroll-tech/go-ethereum/common" | ||
"github.com/scroll-tech/go-ethereum/consensus" | ||
"github.com/scroll-tech/go-ethereum/rpc" | ||
) | ||
|
||
// API is a user facing RPC API to allow controlling the signer and voting | ||
// mechanisms of the proof-of-authority scheme. | ||
type API struct { | ||
chain consensus.ChainHeaderReader | ||
} | ||
|
||
// GetSigners retrieves the list of authorized signers at the specified block. | ||
func (api *API) GetSigners(number *rpc.BlockNumber) ([]common.Address, error) { | ||
return nil, nil | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.