Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow removing txns from pool via CLI/RPC #1041

Merged
merged 5 commits into from
Sep 16, 2024
Merged

feat: allow removing txns from pool via CLI/RPC #1041

merged 5 commits into from
Sep 16, 2024

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

0xmountaintop
0xmountaintop previously approved these changes Sep 13, 2024
View reviewed changes
colinlyguo
colinlyguo previously approved these changes Sep 13, 2024
View reviewed changes
georgehao
georgehao previously approved these changes Sep 13, 2024
View reviewed changes
0xmountaintop
0xmountaintop previously approved these changes Sep 16, 2024
View reviewed changes
@omerfirmak omerfirmak merged commit 521a074 into develop Sep 16, 2024
@omerfirmak omerfirmak deleted the omerfirmak/txpool-remove branch September 16, 2024 10:56
0xmountaintop pushed a commit that referenced this pull request Oct 9, 2024
@omerfirmak @0xmountaintop
feat: allow removing txns from pool via CLI/RPC (#1041)
8daafb6
0xmountaintop added a commit that referenced this pull request Oct 9, 2024
@0xmountaintop @omerfirmak
feat: allow removing txns from pool via CLI/RPC (#1059)
bb4b703 
* feat: allow removing txns from pool via CLI/RPC (#1041)

* fix

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonastheis jonastheis jonastheis approved these changes

@0xmountaintop 0xmountaintop 0xmountaintop approved these changes

@georgehao georgehao georgehao left review comments

@colinlyguo colinlyguo colinlyguo left review comments

Assignees
No one assigned
Labels
bump-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omerfirmak @jonastheis @georgehao @0xmountaintop @colinlyguo