refactor: eliminate double re-execution in AsyncChecker #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
previously approved these changes
Sep 12, 2024
colinlyguo
previously approved these changes
Sep 12, 2024
colinlyguo
reviewed
Sep 12, 2024
omerfirmak
dismissed stale reviews from colinlyguo and 0xmountaintop
via
21ff683
omerfirmak
force-pushed
the
omerfirmak/less-state-access
branch
2 times, most recently
from
cd69b8f to
21ff683
Compare
omerfirmak
force-pushed
the
omerfirmak/less-state-access
branch
from
c07c23c to
97c0cf8
Compare
colinlyguo
approved these changes
Sep 13, 2024
0xmountaintop
approved these changes
Sep 16, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Oct 10, 2024
5 tasks
0xmountaintop
pushed a commit
that referenced
this pull request
Oct 10, 2024
0xmountaintop
added a commit
that referenced
this pull request
Oct 10, 2024
* refactor: eliminate double re-execution in AsyncChecker (#1036) * fix: make reorg mode explicit (#1049) * fix: avoid committing empty blocks after the deadline (#1051) * fix: initialize pending block with an empty block (#1052) * fix: reuse timestamp for blocks failing CCC (#1031) we assume that same height wont trigger multiple reorgs to be able to put an upper bound on the reorg depth. We rely on the fact that AsyncChecker executes transactions one-by-one and tells worker the safe set of transactions to include in the replacement block that wont trigger another error on the same block. If worker changes the timestamp and that causes significant changes to the execution flow of included transactions; we might have a height where multiple reorgs happen. --------- Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
lwedge99
pushed a commit
to sentioxyz/scroll-geth
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
as pointed out by @lispc as well,
core.ApplyTransactionis not really needed. This will also help with reducing contention on the state database, that can potentially interfere with block building in worker.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?