fix elm-review!

Author: kutyel

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2019 Niklas Holmgren
+Copyright © 2024 Scrive
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

src/Json/Schema/Form.elm

@@ -17,9 +17,6 @@ module Json.Schema.Form exposing
 
 @docs init, update
 
-
-# View
-
 @docs view, submit
 
 
@@ -30,8 +27,8 @@ module Json.Schema.Form exposing
 -}
 
 import Dict exposing (Dict)
-import Form as F exposing (Msg(..))
-import Html exposing (..)
+import Form as F exposing (Msg)
+import Html exposing (Html)
 import Json.Schema.Definitions exposing (Schema)
 import Json.Schema.Form.Default exposing (default)
 import Json.Schema.Form.Error exposing (ErrorValue, Errors)
@@ -81,6 +78,7 @@ init options schema =
 update : Msg -> State -> State
 update msg state =
     let
+        form : F.Form ErrorValue Value
         form =
             F.update
                 (validation state.options.formats state.schema)

src/Json/Schema/Form/Default.elm

@@ -1,6 +1,6 @@
 module Json.Schema.Form.Default exposing (default)
 
-import Form.Field exposing (..)
+import Form.Field exposing (Field, bool, group, list, string)
 import Json.Decode
 import Json.Schema.Definitions
     exposing
@@ -16,12 +16,8 @@ import Json.Schema.Definitions
 default : Schema -> List ( String, Field )
 default schema =
     case schema of
-        BooleanSchema bool ->
-            if bool then
-                []
-
-            else
-                []
+        BooleanSchema _ ->
+            []
 
         ObjectSchema objectSchema ->
             subSchema objectSchema
@@ -63,8 +59,7 @@ field ( name, schema ) =
                                 |> Maybe.withDefault []
 
                         UnionType types ->
-                            List.map (singleType schema_ value) types
-                                |> List.filterMap identity
+                            List.filterMap (singleType schema_ value) types
                                 |> List.map (\f -> ( name, f ))
 
                 Nothing ->
@@ -88,8 +83,7 @@ anyType value =
         |> Result.map (List.map string)
         |> Result.map list
     ]
-        |> List.map Result.toMaybe
-        |> List.filterMap identity
+        |> List.filterMap Result.toMaybe
         |> List.head
 
 
@@ -163,16 +157,8 @@ asString : Json.Decode.Decoder String
 asString =
     Json.Decode.oneOf
         [ Json.Decode.string
-        , Json.Decode.int
-            |> Json.Decode.andThen
-                (\a ->
-                    Json.Decode.succeed (String.fromInt a)
-                )
-        , Json.Decode.float
-            |> Json.Decode.andThen
-                (\a ->
-                    Json.Decode.succeed (String.fromFloat a)
-                )
+        , Json.Decode.int |> Json.Decode.map String.fromInt
+        , Json.Decode.float |> Json.Decode.map String.fromFloat
         ]
 
 

src/Json/Schema/Form/Encode.elm

@@ -2,53 +2,51 @@ module Json.Schema.Form.Encode exposing (encode)
 
 {-| Encode form values as JSON.
 
-
-# Encode
-
 @docs encode
 
 -}
 
-import Json.Encode exposing (..)
+import Json.Encode as Encode
 import Json.Schema.Form.Value exposing (Value(..))
 
 
 {-| Encode a form value (the output of a valid form) as JSON.
 -}
-encode : Value -> Json.Encode.Value
+encode : Value -> Encode.Value
 encode value =
     case value of
         IntValue intValue ->
-            int intValue
+            Encode.int intValue
 
         FloatValue floatValue ->
-            float floatValue
+            Encode.float floatValue
 
         StringValue stringValue ->
-            string stringValue
+            Encode.string stringValue
 
         BoolValue boolValue ->
-            bool boolValue
+            Encode.bool boolValue
 
         ListValue valueList ->
-            list encode valueList
+            Encode.list encode valueList
 
         ObjectValue objectValue ->
             let
+                item : ( String, Value ) -> Maybe ( String, Encode.Value )
                 item ( name, val ) =
                     if val == EmptyValue then
                         Nothing
 
                     else
                         Just ( name, encode val )
             in
-            object (List.filterMap item objectValue)
+            Encode.object (List.filterMap item objectValue)
 
         NullValue ->
-            null
+            Encode.null
 
         EmptyValue ->
-            object []
+            Encode.object []
 
         JsonValue jsonValue ->
             jsonValue