Fix the Subject::getParts() method

Author: danmichaelo

CHANGELOG.md

@@ -6,7 +6,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
-None yet
+### Fixed
+
+- Fixed the `Subject::getParts()` method.
 
 ## [2.0.1] - 2019-01-09
 

src/Fields/Subject.php

@@ -88,7 +88,7 @@ public function getId()
 
     public function getParts()
     {
-        return $this->getSubfields(self::$termComponentCodes);
+        return $this->getSubfields('[' . implode('', self::$termComponentCodes) . ']', true);
     }
 
     public function getTerm()

tests/SubjectFieldTest.php

@@ -16,6 +16,13 @@ public function testSubjectString()
         $this->assertEquals('lcsh', $sub->vocabulary);
         $this->assertEquals(Subject::TOPICAL_TERM, $sub->type);
         $this->assertEquals('Eightfold way (Nuclear physics) : Addresses, essays, lectures', strval($sub));
+        $this->assertEquals('Eightfold way (Nuclear physics) : Addresses, essays, lectures', $sub->getTerm());
+
+        $sf0 = new \File_MARC_Subfield('a', 'Eightfold way (Nuclear physics)');
+        $sf0->setPosition(0);
+        $sf1 = new \File_MARC_Subfield('x', 'Addresses, essays, lectures');
+        $sf1->setPosition(1);
+        $this->assertEquals([$sf0, $sf1], $sub->getParts());
     }
 
     public function testChopPunctuation()
@@ -33,12 +40,14 @@ public function testSubjects()
     {
         $record = $this->getNthrecord('sru-alma.xml', 3);
 
-        # Vocabulary from subfield 2
         $subject = $record->subjects[1];
         $this->assertInstanceOf('Scriptotek\Marc\Fields\Subject', $subject);
         $this->assertEquals('noubomn', $subject->vocabulary);
         $this->assertEquals('Elementærpartikler', strval($subject));
         $this->assertEquals(Subject::TOPICAL_TERM, $subject->getType());
+        $this->assertEquals('Elementærpartikler', $subject->getTerm());
+        $this->assertEquals([new \File_MARC_Subfield('a', 'Elementærpartikler')], $subject->getParts());
+
         $this->assertNull($subject->getId());
     }