Skip to content

Commit 9176dbc

Browse files
author
Maneesh
committed
pattern match content header
1 parent aa7effd commit 9176dbc

File tree

2 files changed

+4
-27
lines changed

2 files changed

+4
-27
lines changed

lib/kite_connect_ex/request.ex

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,6 @@ defmodule KiteConnectEx.Request do
1818
@spec api_version() :: String.t()
1919
def api_version, do: @api_version
2020

21-
@spec get_csv(String.t(), map() | nil, list, list) :: Response.success() | Response.error()
22-
def get_csv(path, query, headers, opts \\ []) do
23-
HTTPoison.get(
24-
build_url(path, query),
25-
build_headers(headers),
26-
request_options(opts)
27-
)
28-
|> parse_csv_response()
29-
end
30-
3121
@spec get(String.t(), map() | nil, list, list) :: Response.success() | Response.error()
3222
def get(path, query, headers, opts \\ []) do
3323
HTTPoison.get(
@@ -117,10 +107,6 @@ defmodule KiteConnectEx.Request do
117107
Response.parse_response(response)
118108
end
119109

120-
defp parse_csv_response({:ok, response}) do
121-
Response.parse_csv_response(response)
122-
end
123-
124110
defp parse_response({:error, error}) do
125111
Response.parse_error(error)
126112
end

lib/kite_connect_ex/response.ex

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,20 @@ defmodule KiteConnectEx.Response do
77
@success_status "success"
88
@error_status "error"
99

10-
@doc false
11-
@spec parse_csv_response(HTTPoison.Response.t()) :: success | error
12-
def parse_csv_response(%HTTPoison.Response{} = response) do
13-
case response do
14-
%{body: body, status_code: status} when status in @success_status_codes ->
15-
{:ok, body}
16-
17-
%{body: body, status_code: _status} ->
18-
{:error, KiteConnectEx.Error.new(body)}
19-
end
20-
end
21-
2210
@doc false
2311
@spec parse_response(HTTPoison.Response.t()) :: success | error
2412
def parse_response(%HTTPoison.Response{} = response) do
2513
case response do
14+
%{body: body, headers: [_ | [{"Content-Type", "text/csv"} | _tail]]} ->
15+
{:ok, body}
16+
2617
%{body: body, status_code: status} when status in @success_status_codes ->
2718
body =
2819
body
2920
|> Jason.decode!()
3021
|> parse_body()
3122

32-
{:ok, body}
23+
{:ok, body}
3324

3425
%{body: body, status_code: _status} ->
3526
error =

0 commit comments

Comments
 (0)