Skip to content

Conversation

Femimat
Copy link
Contributor

@Femimat Femimat commented Oct 7, 2025

Contributor checklist


Description

This pull request updates the background colors for the mini keyboard popup to match the app’s day and night themes.
Previously, the popup background color only adapted correctly in dark mode, but not in light mode.
This fix ensures consistent theming across both modes by updating the corresponding color values in colors.xml and colors-night.xml.

Related issue

Copy link

github-actions bot commented Oct 7, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Oct 7, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Hey @Femimat 👋 I'm realizing that I might have been confused by the plans for this. Would we be able to add a small shadow to the views that's similar to what's under the keys? The background color for the alternate keys view should be the same as they keyboard background color. It'd be good if we had a shadow under it so it's clear that it's above they keyboard interface :)

@Femimat
Copy link
Contributor Author

Femimat commented Oct 8, 2025

Hi @andrewtavis, I understand better now. I’ll go over it and see how I can implement the design.

@andrewtavis
Copy link
Member

Sounds good, @Femimat! Looking forward to the update 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants