Skip to content

feat: adding new api methods and prefix parameter #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 14, 2022

Conversation

admon84
Copy link
Member

@admon84 admon84 commented Apr 7, 2021

This is a sizable update to the Python screepsapi library to bring it up-to-date with the latest Screeps API endpoints available on official servers.

I've tried to do my best to implement these changes being mindful not to break other projects using this library as a dependency.

Proposed Changes

  • Adding methods for more Screeps API endpoints (credits: node-screeps-api/RawAPI.js)
  • Added new prefix parameter for API and Socket connections
    • The prefix parameter provides flexibility to use values "/ptr" for public test realm or "/season" for seasonal server.
    • This would replace the need for the ptr parameter, but I also kept ptr to prevent breaking any projects using it.
  • Added a few constants, such as DEFAULT_SHARD to replace hardcoding "shard0"

@admon84 admon84 marked this pull request as ready for review April 7, 2021 01:55
@admon84
Copy link
Member Author

admon84 commented Apr 7, 2021

Is this repo still maintained? If so, please review this PR when you find the time. Thanks!

@AlinaNova21
Copy link
Member

This looks good to me, although I personally haven't used this library myself and would like someone whos used it and is more familiar with python than me to look it over.

@admon84 admon84 marked this pull request as draft May 5, 2021 00:46
@admon84 admon84 marked this pull request as ready for review May 6, 2021 05:08
@admon84 admon84 merged commit f90eb02 into screepers:master Feb 14, 2022
@admon84 admon84 deleted the dev branch February 14, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants