Fix _findLargestStrokeWidth to avoid regression

adroitwhiz · adroitwhiz · commit 6f81e0df88b4 · 2020-02-14T11:11:31.000-05:00
diff --git a/src/svg-renderer.js b/src/svg-renderer.js
@@ -308,7 +308,7 @@ class SvgRenderer {
         let largestStrokeWidth = 0;
         const collectStrokeWidths = domElement => {
             if (domElement.getAttribute) {
-                if (domElement.getAttribute('stroke')) {
+                if (domElement.getAttribute('stroke') && domElement.getAttribute('stroke') !== 'none') {
                     largestStrokeWidth = Math.max(largestStrokeWidth, 1);
                 }
                 if (domElement.getAttribute('stroke-width')) {

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ class SvgRenderer {`
`308`	`308`	`let largestStrokeWidth = 0;`
`309`	`309`	`const collectStrokeWidths = domElement => {`
`310`	`310`	`if (domElement.getAttribute) {`
`311`		`- if (domElement.getAttribute('stroke')) {`
	`311`	`+ if (domElement.getAttribute('stroke') && domElement.getAttribute('stroke') !== 'none') {`
`312`	`312`	`largestStrokeWidth = Math.max(largestStrokeWidth, 1);`
`313`	`313`	`}`
`314`	`314`	`if (domElement.getAttribute('stroke-width')) {`