fix: set a "clean" flag on assets #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Resolves an issue we saw in smoke test, related to scratchfoundation/scratch-gui#4181
Add a "clean" flag to assets. Assets that get updated WITHOUT requiring an assetId change are set to CLEAN, assets that require id updates are NOT CLEAN.
This is used by the GUI to only save assets that are NOT CLEAN.
A circumstance where an asset is marked as clean would be loading from any of the helpers. (
asset.setData(...)without generateId flag)A circumstance where an asset is marked as not clean would be when the VM loads a 2.0 costume that needs to be updated in storage after being modified. (
asset.setData(..., true))Another circumstance where an asset is marked as not clean is when it is created by the costume editor (
storage.createAsset(..., true))