Skip to content

Conversation

@benjiwheeler
Copy link
Contributor

Resolves

Resolves #262

Proposed Changes

  • removes travis-after-all library
  • in .travis.yml, replaces after_script with deploy section

Testing plan

  • see that after merge, this causes a deploy to npm with a new minor version number

@benjiwheeler
Copy link
Contributor Author

Don't know why the package-lock.json changes are so large -- I ran npm uninstall travis-after-all --save and didn't npm install

Copy link
Contributor

@rschamp rschamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rschamp rschamp assigned benjiwheeler and unassigned rschamp Apr 26, 2021
@benjiwheeler benjiwheeler merged commit 1b0f2bb into scratchfoundation:develop Apr 26, 2021
@benjiwheeler benjiwheeler deleted the fix-travis-all branch April 26, 2021 22:36
@rschamp
Copy link
Contributor

rschamp commented Apr 27, 2021

🎉 This PR is included in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scratch-storage not deploying to npm

2 participants