chore: update eslint version, modify hasOwnProperty calls #192
Conversation
| _TextDecoder = encoding.TextDecoder; | ||
| _TextEncoder = encoding.TextEncoder; | ||
| } else { | ||
| /* global TextDecoder TextEncoder */ |
There was a problem hiding this comment.
re: this change, see eslint/eslint#11979 and discussion at https://scratchteam.slack.com/archives/CS1144QCE/p1604958351210800
|
Need to find reviewer |
benjiwheeler
force-pushed
the
update-eslint
branch
from
a0e18a7 to
21469a5
Compare
benjiwheeler
force-pushed
the
update-eslint
branch
from
ca53a8e to
9349eca
Compare
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
This all looks reasonable to me. Just one point of confusion.
| "cz-conventional-changelog": "^3.0.2", | ||
| "eslint": "5.7.0", | ||
| "eslint-config-scratch": "5.1.0", | ||
| "eslint-plugin-react": "7.12.4", |
There was a problem hiding this comment.
Is the addition of the major version range ^ for eslint-config-scratch and eslint-plugin-react but not eslint or babel-eslint intentional?
There was a problem hiding this comment.
As I recall, some other repo of ours had that pattern -- but now I can't find it! I checked around, and it seems like we're generally using the major version caret for eslint, so I added it here.
|
🎉 This PR is included in version 1.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
Resolves #191