Skip to content

Commit 1f05cb4

Browse files
authored
Merge pull request #41 from kchadha/fix-sprite2
fix(sprite2): sprite2 validation should allow sprites without sounds
2 parents 4250b52 + af53ae2 commit 1f05cb4

File tree

4 files changed

+15
-2
lines changed

4 files changed

+15
-2
lines changed

lib/sb2_definitions.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@
103103
"additionalProperties": true,
104104
"required": [
105105
"objName",
106-
"sounds",
107106
"costumes",
108107
"currentCostumeIndex"
109108
]

test/fixtures/data.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ module.exports = {
3737
default_cat_sprite2: fs.readFileSync(path.resolve(__dirname, './data/_default_cat.sprite2')),
3838
default_cat_sprite2_json: fs.readFileSync(path.resolve(__dirname, './data/_default_cat.sprite2json')),
3939
example_sprite2: fs.readFileSync(path.resolve(__dirname, './data/_example_sprite.sprite2')),
40-
example_sprite2_json: fs.readFileSync(path.resolve(__dirname, './data/_example_sprite.sprite2json'))
40+
example_sprite2_json: fs.readFileSync(path.resolve(__dirname, './data/_example_sprite.sprite2json')),
41+
bananas_sprite2: fs.readFileSync(path.resolve(__dirname, './data/_bananas.sprite2'))
4142
},
4243
sb: sb,
4344
sb2: sb2,

test/fixtures/data/_bananas.sprite2

4.79 KB
Binary file not shown.

test/integration/sprites.js

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,19 @@ test('example sprite2', function (t) {
2929
});
3030
});
3131

32+
test('banana sprite2, no sounds', function (t) {
33+
parser(data.sprites.bananas_sprite2, true, function (err, result) {
34+
t.equal(err, null);
35+
t.equal(Array.isArray(result), true);
36+
var res = result[0];
37+
var possibleZip = result[1];
38+
t.type(res, 'object');
39+
t.equal(res.projectVersion, 2);
40+
t.equal(possibleZip instanceof JSZip, true);
41+
t.end();
42+
});
43+
});
44+
3245
test('default cat sprite2 json', function (t) {
3346
parser(data.sprites.default_cat_sprite2_json, true, function (err, result) {
3447
t.equal(err, null);

0 commit comments

Comments
 (0)