simplify props of cloud-manager-hoc

[benjiwheeler]

Proposed Changes

• removes shouldNotModifyCloudData function and replaces it with prop canModifyCloudData (with opposite boolean value)
• Sets prop defaults so that code which renders GUI (such as www's embed view) can safely omit most props, and trust GUI to still render as expected

[rschamp]

I think adding CloudManager.defaultProps is a good idea. However I think we should leave canSave as .isRequired, since previously we had decided to try to keep as many things as required as possible, unless they are explicitly not required. The strictness helps things from being overlooked as props change.

[benjiwheeler]

I think adding CloudManager.defaultProps is a good idea. However I think we should leave canSave as .isRequired, since previously we had decided to try to keep as many things as required as possible, unless they are explicitly not required. The strictness helps things from being overlooked as props change.

Take a look now. I added isRequired to each propType where it seems appropriate.

[rschamp]

Also confused why this is a prop for CloudManager, even though you haven't touched that.

[benjiwheeler]

I don't know what you mean about having touched that. For why canSave is a prop here, see my comment above, at #5198 (comment)

[rschamp]

By "you haven't touched that", I was just acknowledging that this line isn't necessarily in scope for this PR since it's unchanged.

[rschamp]

While I see why it is the way it is, the way canSave is used is counterintuitive to me. I think it would be more understandable if shouldNotModifyCloudData was a prop for CloudManagerHOC.

[rschamp]

By "you haven't touched that", I was just acknowledging that this line isn't necessarily in scope for this PR since it's unchanged.

[benjiwheeler]

Next steps:

• make shouldNotModifyCloudData into a prop, using ownProps
• don't set default for canSave

[benjiwheeler]

note that I switched the boolean value of shouldNotModifyCloudData canModifyCloudData.

There's potential confusion with hasCloudPermission, which in www is set to isScratcher; I have ideas for further simplification here, but I think we should take it one step at a time.