Update eslint-plugin-react and fix newly discovered lint errors. #4786
Conversation
This includes a small bug where the target pane wouldn't automatically update if changes to the sprite occured while in fullscreen/player mode. Closes scratchfoundation#4221
| } | ||
|
|
||
| // Re-request a targets update when the shouldEmitTargetsUpdate state changes to true | ||
| // Re-request a targets update when the shouldEmitUpdate state changes to true |
There was a problem hiding this comment.
This one seems like it uncovered an error; I think it was introduced here: c799541
Does this need to be tested before we make this change?
There was a problem hiding this comment.
Yup, mentioned that in the PR
The lint fixes were mostly just missing proptypes, not real bugs. But this includes a small bug where the target pane wouldn't automatically update if changes to the sprite occurred while in fullscreen/player mode (in vm-listener-hoc)
I did check manually that that issue was fixed.
benjiwheeler
left a comment
benjiwheeler
left a comment
There was a problem hiding this comment.
Mostly LGTM; tests failed, but I think it was just that intermittent blocks failure that's not real. (Restarted tests.)
|
Blocked on tests failing (rerunning now), and the one possible |
|
Third time restarting identical travis build was the charm! :( |
2 participants
We had pinned this dependency because it once started causing build failures (#4215) but then by not automatically getting updates, and not merging the new greenkeeper updates (#4221) we didn't see errors that should have been caught by the linter. The old version of the linter didn't catch undefined prop issues completely, which is why this issue wasn't caught by the linter. :sigh:
Talking with @benjiwheeler we decided to unpin it to get new updates, leaning towards possibly breaking the build instead of possibly missing important updates that can catch bugs.
The lint fixes were mostly just missing proptypes, not real bugs. But this includes a small bug where the target pane wouldn't automatically update if changes to the sprite occurred while in fullscreen/player mode (in vm-listener-hoc)
Closes #4221