project state reducer tests, bug fixes #3360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjiwheeler
force-pushed
the
project-state-reducer-tests
branch
from
c56707b to
5933082
Compare
rschamp
reviewed
Oct 15, 2018
Contributor
rschamp
left a comment
rschamp
left a comment
There was a problem hiding this comment.
The tests look good, thanks for adding them. Just curious about the parseInt piece — I would like to avoid that if possible.
Contributor
Author
|
Take a look now -- I think I've addressed your points |
rschamp
reviewed
Oct 16, 2018
rschamp
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #3348
Proposed Changes