Skip to content

Commit bf2f606

Browse files
set lang in constructor and updateHandler not in render
1 parent 27de652 commit bf2f606

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/containers/language-selector.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@ class LanguageSelector extends React.Component {
1313
bindAll(this, [
1414
'handleChange'
1515
]);
16+
document.documentElement.lang = this.props.currentLocale;
1617
}
1718
handleChange (e) {
1819
const newLocale = e.target.value;
1920
if (this.props.supportedLocales.includes(newLocale)) {
2021
this.props.onChangeLanguage(newLocale);
22+
document.documentElement.lang = newLocale;
2123
}
2224
}
2325
render () {
@@ -27,7 +29,6 @@ class LanguageSelector extends React.Component {
2729
children,
2830
...props
2931
} = this.props;
30-
document.documentElement.lang = this.props.currentLocale; //update the lang attribute of the html for screenreaders
3132
return (
3233
<LanguageSelectorComponent
3334
onChange={this.handleChange}

0 commit comments

Comments
 (0)