Skip to content

Commit 4d3ca75

Browse files
committed
Merge branch 'preloadFonts' of github.com:fsih/scratch-gui into preloadFonts
2 parents e25ab36 + 70f0826 commit 4d3ca75

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+1493
-521
lines changed

README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ npm start
2929
Then go to [http://localhost:8601/](http://localhost:8601/) - the playground outputs the default GUI component
3030

3131
## Developing alongside other Scratch repositories
32+
33+
### Linking this code to another project's `node_modules/scratch-gui`
34+
35+
#### Configuration
36+
3237
If you wish to develop scratch-gui alongside other scratch repositories that depend on it, you may wish
3338
to have the other repositories use your local scratch-gui build instead of fetching the current production
3439
version of the scratch-gui that is found by default using `npm install`.
@@ -43,7 +48,7 @@ To do this:
4348

4449
Instead of `BUILD_MODE=dist npm run build` you can also use `BUILD_MODE=dist npm run watch`, however this may be unreliable.
4550

46-
### Oh no! It didn't work!
51+
#### Oh no! It didn't work!
4752
* Follow the recipe above step by step and don't change the order. It is especially important to run npm first because installing after the linking will reset the linking.
4853
* Make sure the repositories are siblings on your machine's file tree.
4954
* If you have multiple Terminal tabs or windows open for the different Scratch repositories, make sure to use the same node version in all of them.

package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"babel-preset-react": "^6.22.0",
4242
"base64-loader": "1.0.0",
4343
"bowser": "1.9.4",
44-
"chromedriver": "2.42.0",
44+
"chromedriver": "2.42.1",
4545
"classnames": "2.2.6",
4646
"copy-webpack-plugin": "^4.5.1",
4747
"core-js": "2.5.7",
@@ -74,6 +74,7 @@
7474
"postcss-loader": "^3.0.0",
7575
"postcss-simple-vars": "^5.0.1",
7676
"prop-types": "^15.5.10",
77+
"query-string": "^5.1.1",
7778
"raf": "^3.4.0",
7879
"raw-loader": "^0.5.1",
7980
"react": "16.2.0",
@@ -96,13 +97,13 @@
9697
"redux-throttle": "0.1.1",
9798
"rimraf": "^2.6.1",
9899
"scratch-audio": "0.1.0-prerelease.20180625202813",
99-
"scratch-blocks": "0.1.0-prerelease.1539092006",
100-
"scratch-l10n": "3.0.20181004141631",
100+
"scratch-blocks": "0.1.0-prerelease.1539267627",
101+
"scratch-l10n": "3.0.20181010220115",
101102
"scratch-paint": "0.2.0-prerelease.20181010194950",
102103
"scratch-render": "0.1.0-prerelease.20181002192350",
103104
"scratch-storage": "1.0.4",
104105
"scratch-svg-renderer": "0.2.0-prerelease.20180926143036",
105-
"scratch-vm": "0.2.0-prerelease.20181010193639",
106+
"scratch-vm": "0.2.0-prerelease.20181011142759",
106107
"selenium-webdriver": "3.6.0",
107108
"startaudiocontext": "1.2.1",
108109
"style-loader": "^0.23.0",

src/components/cards/cards.jsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,18 @@ const VideoStep = ({video, dragging}) => (
6464
) : null}
6565
<iframe
6666
allowFullScreen
67-
allow="autoplay; encrypted-media"
67+
allowTransparency="true"
6868
frameBorder="0"
69-
height="337"
70-
src={`${video}?rel=0&amp;showinfo=0`}
69+
height="338"
70+
scrolling="no"
71+
src={`https://fast.wistia.net/embed/iframe/${video}?seo=false&videoFoam=true`}
72+
title="📹"
7173
width="600"
7274
/>
75+
<script
76+
async
77+
src="https://fast.wistia.net/assets/external/E-v1.js"
78+
/>
7379
</div>
7480
);
7581

src/components/gui/gui.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,12 @@ $fade-out-distance: 15px;
279279
margin-top: 0;
280280
}
281281

282+
/* Menu */
283+
284+
.menu-bar-position {
285+
position: relative;
286+
z-index: $z-index-menu-bar;
287+
}
282288
/* Alerts */
283289

284290
.alerts-container {

src/components/gui/gui.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ const GUIComponent = props => {
164164
) : null}
165165
<MenuBar
166166
accountNavOpen={accountNavOpen}
167+
className={styles.menuBarPosition}
167168
enableCommunity={enableCommunity}
168169
renderLogin={renderLogin}
169170
onClickAccountNav={onClickAccountNav}

src/components/language-selector/language-selector.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
@import "../../css/colors.css";
22
@import "../../css/units.css";
33

4-
.language-icon {
5-
height: 1.5rem;
6-
}
7-
84
/* Position the language select over the language icon, and make it transparent */
95
.language-select {
106
position: absolute;

src/components/menu-bar/menu-bar.css

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,11 @@
4747

4848
.language-icon {
4949
height: 1.5rem;
50+
vertical-align: middle;
5051
}
5152

5253
.language-caret {
53-
margin-bottom: .625rem;
54+
margin: 0 .125rem;
5455
}
5556

5657
.language-menu {
@@ -100,6 +101,10 @@
100101
padding: 0 0.75rem;
101102
}
102103

104+
.menu-bar-item.language-menu {
105+
padding: 0 0.5rem;
106+
}
107+
103108
.menu-bar-menu {
104109
margin-top: $menu-bar-height;
105110
z-index: $z-index-menu-bar;

0 commit comments

Comments
 (0)