Shadow blocks with only labels are too small

[rachel-fenichel]

Expected Behavior

The first boolean1 block should be the same height as the second boolean1 block:

Same for these two string1 blocks:

Actual Behavior

The first block is shorter, because it's a shadow. There are currently no shadow blocks with only labels on the playground. The argument reporters for custom blocks will be shadows.

The same problem happens for strings as for booleans, but it's less noticeable because the text doesn't run into the edge as clearly.

[rachel-fenichel]

The height problem is because of an overly broad rule in computeInputHeight. It hits the first branch (for lone field blocks) below. Removing the isShadow check gives the right height for this block.

/**
 * Compute the minimum height of this input.
 * @param {!Blockly.Input} input The input to measure.
 * @param {!Object} row The row of the block that is currently being measured.
 * @param {!Object} previousRow The previous row of the block, which was just
 *     measured.
 * @return {number} the computed height of this input.
 * @private
 */
Blockly.BlockSvg.prototype.computeInputHeight_ = function(input, row,
    previousRow) {
  if (this.inputList.length === 1 && this.isShadow() && this.outputConnection) {
    // "Lone" field blocks are smaller.
    return Blockly.BlockSvg.MIN_BLOCK_Y_SINGLE_FIELD_OUTPUT;
  } else if (this.outputConnection) {
    // All other reporters.
    return Blockly.BlockSvg.MIN_BLOCK_Y_REPORTER;
  } else if (row.type == Blockly.NEXT_STATEMENT) {
    // Statement input.
    return Blockly.BlockSvg.MIN_STATEMENT_INPUT_HEIGHT;
  } else if (previousRow && previousRow.type == Blockly.NEXT_STATEMENT) {
    // Extra row for below statement input.
    return Blockly.BlockSvg.EXTRA_STATEMENT_ROW_Y;
  } else {
    // All other blocks.
    return Blockly.BlockSvg.MIN_BLOCK_Y;
  }
};

And the width problem is from a similar check in computeOutputPadding. Again, removing the isShadow check gives the correct width:

/**
 * For a block with output,
 * determine start and end padding, based on connected inputs.
 * Padding will depend on the shape of the output, the shape of the input,
 * and possibly the size of the input.
 * @param {!Array.<!Array.<!Object>>} inputRows Partially calculated rows.
 */
Blockly.BlockSvg.prototype.computeOutputPadding_ = function(inputRows) {
  // Only apply to blocks with outputs and not single fields (shadows).
  if (!this.getOutputShape() || !this.outputConnection || this.isShadow()) {
    return;
  }
  ...
}