Hidden workspace still responds to keyboard events

[paulkaplan]

Expected Behavior

Please describe what should happen

A hidden workspace should not respond to keyboard undo/redo.

Actual Behavior

Describe what actually happens

After a call to workspace.setVisible(false), you can still undo/redo using the keyboard.

Steps to Reproduce

Explain what someone needs to do in order to see what's described in Actual behavior above

1. Open the vertical playground
2. Add some blocks, move some things around.
3. Press "Hide"
4. Undo using the keyboard (cmd + z)
5. Press "Show"
6. The last operation has been undone while the workspace was hidden.

[paulkaplan]

@rachel-fenichel is there any legit use case for keeping that behavior? If not, should this be filed as a bug upstream on blockly?

[paulkaplan]

update: submitted the following as #1020

First impression fix would be to add a third short-circuit condition to Blockly.onKeyDown_, changing

Blockly.onKeyDown_ = function(e) {
  if (Blockly.mainWorkspace.options.readOnly || Blockly.utils.isTargetInput(e)) { ...

to

Blockly.onKeyDown_ = function(e) {
  if (Blockly.mainWorkspace.options.readOnly || Blockly.utils.isTargetInput(e) ||
    !Blockly.mainWorkspace.rendered) { ...

But it doesn't seem that workspace.setVisible sets the rendered property to false. Is that by design? Is there a different visibility check I could do? Or should I added this.rendered = isVisible to the end of the setVisible function?

[rachel-fenichel]

I need to check whether that's a valid use of rendered. The comment on it says

/**
 * The render status of an SVG workspace.
 * Returns `true` for visible workspaces and `false` for non-visible,
 * or headless, workspaces.
 * @type {boolean}
 */
Blockly.WorkspaceSvg.prototype.rendered = true;

but I'm not convinced that hidden rendered workspaces are the same as non-rendered workspaces at this point. I'd rather have a visible attribute and have rendered only cover the difference between a workspace and a workspaceSvg.

[fsih]

I was pretty confused about the difference between rendered and isVisible when I was in this code before. When is a hidden rendered workspace supposed to exist?

[rachel-fenichel]

If you open the blockly playground and then click "hide", you have a hidden rendered workspace.