Skip to content

Commit c101e4c

Browse files
committed
Add missing tests for remaining effects
1 parent e68f02e commit c101e4c

File tree

3 files changed

+39
-3
lines changed

3 files changed

+39
-3
lines changed

test/graphicseffect/graphicseffect_test.cpp

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,31 @@ TEST(GraphicsEffectTest, Clamp)
5454
ASSERT_EQ(effect.clamp(125), 100);
5555
}
5656

57-
// TODO: Test remaining effects
57+
{
58+
GraphicsEffect effect(ShaderManager::Effect::Fisheye, "fisheye");
59+
ASSERT_EQ(effect.clamp(-5000), -5000);
60+
ASSERT_EQ(effect.clamp(0), 0);
61+
ASSERT_EQ(effect.clamp(5000), 5000);
62+
}
63+
64+
{
65+
GraphicsEffect effect(ShaderManager::Effect::Whirl, "whirl");
66+
ASSERT_EQ(effect.clamp(-5000), -5000);
67+
ASSERT_EQ(effect.clamp(0), 0);
68+
ASSERT_EQ(effect.clamp(5000), 5000);
69+
}
70+
71+
{
72+
GraphicsEffect effect(ShaderManager::Effect::Pixelate, "pixelate");
73+
ASSERT_EQ(effect.clamp(-5000), -5000);
74+
ASSERT_EQ(effect.clamp(0), 0);
75+
ASSERT_EQ(effect.clamp(5000), 5000);
76+
}
77+
78+
{
79+
GraphicsEffect effect(ShaderManager::Effect::Mosaic, "mosaic");
80+
ASSERT_EQ(effect.clamp(-5000), -5000);
81+
ASSERT_EQ(effect.clamp(0), 0);
82+
ASSERT_EQ(effect.clamp(5000), 5000);
83+
}
5884
}

test/renderedtarget/renderedtarget_test.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,12 @@ TEST_F(RenderedTargetTest, CpuRendering)
471471
ASSERT_EQ(target.colorAtScratchPoint(-224.7, 161.5), 4278222912); // [3.3, 3.5]
472472
target.setGraphicEffect(ShaderManager::Effect::Color, 0);
473473

474-
// TODO: Test point transform (graphic effects that change shape)
474+
target.setGraphicEffect(ShaderManager::Effect::Whirl, 100);
475+
ASSERT_EQ(target.colorAtScratchPoint(-227, 162), 4286578816); // [1, 3]
476+
ASSERT_EQ(target.colorAtScratchPoint(-226, 162), 4286611711); // [2, 3]
477+
ASSERT_EQ(target.colorAtScratchPoint(-225, 162), 0); // [3, 3]
478+
ASSERT_EQ(target.colorAtScratchPoint(-224.7, 161.5), 0); // [3.3, 3.5]
479+
target.setGraphicEffect(ShaderManager::Effect::Whirl, 100);
475480
}
476481

477482
TEST_F(RenderedTargetTest, SpriteDragging)

test/texture/cputexturemanager_test.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,12 @@ TEST_F(CpuTextureManagerTest, TextureContainsPoint)
218218
ASSERT_TRUE(manager.textureContainsPoint(texture, { 3, 3 }, mask, {}));
219219
ASSERT_TRUE(manager.textureContainsPoint(texture, { 3.3, 3.5 }, mask, {}));
220220

221-
// TODO: Test point transform (graphic effects that change shape)
221+
mask = ShaderManager::Effect::Whirl;
222+
const std::unordered_map<ShaderManager::Effect, double> effects = { { ShaderManager::Effect::Whirl, 100 } };
223+
ASSERT_TRUE(manager.textureContainsPoint(texture, { 1, 3 }, mask, effects));
224+
ASSERT_TRUE(manager.textureContainsPoint(texture, { 2, 3 }, mask, effects));
225+
ASSERT_FALSE(manager.textureContainsPoint(texture, { 3, 3 }, mask, effects));
226+
ASSERT_FALSE(manager.textureContainsPoint(texture, { 3.3, 3.5 }, mask, effects));
222227

223228
// Cleanup
224229
emit context.aboutToBeDestroyed();

0 commit comments

Comments
 (0)