Merge pull request #414 from scratchcpp/reserved_target_names

Add reserved target names

Author: adazem009

src/scratch/target.cpp

@@ -7,10 +7,14 @@
 #include <scratchcpp/comment.h>
 #include <scratchcpp/iengine.h>
 
+#include <unordered_set>
+
 #include "target_p.h"
 
 using namespace libscratchcpp;
 
+static const std::unordered_set<std::string> RESERVED_NAMES = { "_mouse_", "_stage_", "_edge_", "_myself_", "_random_" };
+
 /*! Constructs target. */
 Target::Target() :
     impl(spimpl::make_unique_impl<TargetPrivate>())
@@ -23,10 +27,14 @@ const std::string &Target::name() const
     return impl->name;
 }
 
-/*! Sets the name of the target. */
+/*!
+ * Sets the name of the target.
+ * \note Setting the name to one of the reserved names (_mouse_, _stage_, _edge_, _myself_, _random_) won't do anything.
+ */
 void Target::setName(const std::string &name)
 {
-    impl->name = name;
+    if (RESERVED_NAMES.find(name) == RESERVED_NAMES.cend())
+        impl->name = name;
 }
 
 /*! Returns the list of variables. */

test/scratch_classes/target_test.cpp

@@ -29,6 +29,24 @@ TEST(TargetTest, Name)
     Target target;
     target.setName("Test");
     ASSERT_EQ(target.name(), "Test");
+
+    target.setName("_mouse_");
+    ASSERT_EQ(target.name(), "Test");
+
+    target.setName("_stage_");
+    ASSERT_EQ(target.name(), "Test");
+
+    target.setName("_edge_");
+    ASSERT_EQ(target.name(), "Test");
+
+    target.setName("_myself_");
+    ASSERT_EQ(target.name(), "Test");
+
+    target.setName("_random_");
+    ASSERT_EQ(target.name(), "Test");
+
+    target.setName("Sprite1");
+    ASSERT_EQ(target.name(), "Sprite1");
 }
 
 TEST(TargetTest, Variables)