Add encoding functions #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on the encoding detection in scrapy
| returns a tuple of (encoding used, unicode) | ||
| """ | ||
| enc = http_content_type_encoding(content_type_header) | ||
| bom_enc, rest_of_data = read_bom(html_body_str) |
There was a problem hiding this comment.
Are python byte slices cheap?
Just to point about rest_of_data been copied and later dropped when bom_enc and enc doens't match.
It's a rare case I know, but it waste memory for big responses or for sites sending BOM and different transport encoding for all its pages.
I think this isn't a merge blocker but worth pointing it, once in the wild we can optimize if affects any real case.
There was a problem hiding this comment.
It should be pretty rare that we have BOMs that differ from the encoding in the headers, and it's not that expensive. But still - why take the risk? I'll change it.
The content type header parameter to html_to_unicode has been documented more clearly.
shaneaevans
added a commit
that referenced
this pull request
Feb 14, 2012
Add encoding functions for converting html to unicode
wRAR
pushed a commit
that referenced
this pull request
Aug 24, 2021
Improve ParseDataURIResult documentation
kmike
pushed a commit
that referenced
this pull request
Jun 16, 2022
For issue #162 Add different regex pattern to search for meta tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are loosely based on the encoding in scrapy.
Main differences: