Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple browser contexts #13

Merged
merged 26 commits into from
Jul 16, 2021
Merged

Multiple browser contexts #13

merged 26 commits into from
Jul 16, 2021

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Jun 10, 2021

Closes #12

Tasks:

  • Multiple contexts at startup
  • Create new contexts during a crawl
  • Example spider
  • Settings docs
  • Usage docs
  • Tests
  • Deprecate PLAYWRIGHT_CONTEXT_ARGS in favour of PLAYWRIGHT_CONTEXTS

@elacuesta elacuesta changed the title [WIP] Multiple contexts [WIP] Multiple browser contexts Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #13 (1f51309) into master (68d8fd1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1f51309 differs from pull request most recent head 9c4c687. Consider uploading reports for the commit 9c4c687 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          136       159   +23     
=========================================
+ Hits           136       159   +23     
Impacted Files Coverage Δ
scrapy_playwright/handler.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d8fd1...9c4c687. Read the comment docs.

@elacuesta elacuesta added the enhancement New feature or request label Jun 10, 2021
@elacuesta elacuesta marked this pull request as ready for review June 22, 2021 14:17
@elacuesta elacuesta changed the title [WIP] Multiple browser contexts Multiple browser contexts Jun 22, 2021
@elacuesta
Copy link
Member Author

@kalessin could you take a look at this? Thanks!

README.md Show resolved Hide resolved
@elacuesta elacuesta merged commit d1b2bf1 into master Jul 16, 2021
@elacuesta elacuesta deleted the multiple-contexts branch July 16, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API to handle multiple browser contexts
2 participants