Move annotations from GATE to WebAnnotator format #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
whalebot-helmsman
commented
Sep 15, 2017
whalebot-helmsman
commented
- Add utilities to convert and verify conversion between formats
- Convert current GATE annotations to WebAnnotator format
- Updated example to new annotations placement
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 82.98% 80.86% -2.12%
==========================================
Files 34 37 +3
Lines 1704 1866 +162
==========================================
+ Hits 1414 1509 +95
- Misses 290 357 +67 |
kmike
reviewed
Sep 15, 2017
| str(WEBSTRUCT_DATA / "corpus/us_contact_pages/annotated/*.xml"), | ||
| loader=gate_loader | ||
| str(WEBSTRUCT_DATA / "corpus/us_contact_pages/wa/*.html"), | ||
| loader=wa_loader |
There was a problem hiding this comment.
The docstring is no longer valid, and there is no need to create gate_loader.
|
Looks good, other than a minor issue, thanks @whalebot-helmsman! Could you please fix it in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.