fix .travis.yml #795
Merged
fix .travis.yml #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
approved these changes
Sep 25, 2020
added 2 commits
September 25, 2020 09:49
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 231 231
Lines 2520 2520
=======================================
Hits 2479 2479
Misses 41 41 Continue to review full report at Codecov.
|
Gallaecio
reviewed
Sep 25, 2020
setup.py
Outdated
| @@ -1,7 +1,7 @@ | |||
| import re | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| __version__ = re.match(r"__version__.*\s*=\s*[']([^']+)[']", open('dateparser/__init__.py').read())[1] | |||
| __version__ = re.findall(r"__version__.*\s*=\s*[']([^']+)[']", open('dateparser/__init__.py').read())[0] | |||
There was a problem hiding this comment.
Untested, but this might also work and be closer to the original code:
Suggested change
| __version__ = re.findall(r"__version__.*\s*=\s*[']([^']+)[']", open('dateparser/__init__.py').read())[0] | |
| __version__ = re.search(r"__version__.*\s*=\s*[']([^']+)[']", open('dateparser/__init__.py').read())[1] |
re.match is basically re.search with an implicit ^ in the pattern.
There was a problem hiding this comment.
Nope. The problem is indeed the syntax. Today I learn that is specific to 3.6+.
What about using the old syntax equivalent, .group(1)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.