Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python2/unicode references #783

Merged

Conversation

noviluni
Copy link
Collaborator

for: #727

@noviluni noviluni requested a review from Gallaecio September 11, 2020 10:37
@noviluni noviluni mentioned this pull request Sep 11, 2020
8 tasks
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #783 into master will decrease coverage by 2.79%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
- Coverage   98.37%   95.57%   -2.80%     
==========================================
  Files         231      304      +73     
  Lines        2523     2599      +76     
==========================================
+ Hits         2482     2484       +2     
- Misses         41      115      +74     
Impacted Files Coverage Δ
dateparser/__init__.py 100.00% <ø> (ø)
dateparser/calendars/__init__.py 95.45% <ø> (ø)
dateparser/languages/dictionary.py 99.32% <ø> (ø)
dateparser/languages/loader.py 100.00% <ø> (ø)
dateparser/languages/locale.py 98.64% <ø> (ø)
dateparser/search/__init__.py 100.00% <ø> (ø)
dateparser/search/search.py 99.33% <ø> (ø)
dateparser/date.py 99.57% <100.00%> (ø)
dateparser/search/detection.py 94.33% <0.00%> (-1.58%) ⬇️
dateparser/utils/__init__.py 97.41% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f01811...7f73cf0. Read the comment docs.

@noviluni noviluni force-pushed the remove_python2_unicode_references branch from 0667671 to 7f73cf0 Compare September 14, 2020 21:21
@noviluni noviluni merged commit a18cc09 into scrapinghub:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants