-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create DateData class #778
create DateData class #778
Conversation
aa6ef69
to
2e48121
Compare
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 98.24% 98.30% +0.05%
==========================================
Files 231 231
Lines 2569 2590 +21
==========================================
+ Hits 2524 2546 +22
+ Misses 45 44 -1
Continue to review full report at Codecov.
|
I removed the I changed that part and moved the undocumented |
I improved the coverage @Gallaecio, would you mind to take a look again? 🙂 |
This was motivated by this comment: #729 (comment)
Changing from returning a dict to returning an object seems a better decision, as it gives more control over the results and allows to document the API easier.
This should probably be improved by adding more docs, etc.
This is blocking:
DEBUG_INFO
setting #561