Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update write_complete_data script to remove utf encoding string. #761

Conversation

kishan3
Copy link

@kishan3 kishan3 commented Jul 31, 2020

For #727

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files         304      304           
  Lines        2629     2629           
=======================================
  Hits         2503     2503           
  Misses        126      126           
Impacted Files Coverage Δ
dateparser/data/__init__.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/af.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/agq.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/ak.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/am.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/ar.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/as.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/asa.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/ast.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/az-Cyrl.py 100.00% <ø> (ø)
... and 269 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc91be...5ea523b. Read the comment docs.

Copy link
Collaborator

@noviluni noviluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @kishan3!

@noviluni noviluni mentioned this pull request Aug 4, 2020
8 tasks
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@noviluni noviluni merged commit 749e75d into scrapinghub:master Aug 5, 2020
@noviluni noviluni added this to the v1.0.0 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants