Test for isinstance "set" instead of collections.Set #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter is deprecated in favor of collections.abc.Set, but just "set" should suffice here.
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 95.21% 95.20% -0.01%
==========================================
Files 302 302
Lines 2506 2502 -4
==========================================
- Hits 2386 2382 -4
Misses 120 120
Continue to review full report at Codecov.
|
Gallaecio
approved these changes
Apr 28, 2020
noviluni
approved these changes
Apr 30, 2020
| warn(self.DATE_FORMATS_ERROR_MESSAGE, FutureWarning) | ||
| date_formats = [date_formats] | ||
| elif not (date_formats is None or isinstance(date_formats, (list, tuple, Set))): | ||
| elif not (date_formats is None or isinstance(date_formats, (list, tuple, set))): |
There was a problem hiding this comment.
It's not exactly the same. Set would include subclasses of collections.abc.Set different than set, but I agree that it's better to simplify here, as another implementation shouldn't be used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter is deprecated in favor of collections.abc.Set, but just "set"
should suffice here.