Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable extra runsBefore and runsAfter phases #164

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Configurable extra runsBefore and runsAfter phases #164

merged 1 commit into from
Jun 1, 2016

Conversation

pbatko
Copy link
Contributor

@pbatko pbatko commented May 9, 2016

Relevant issue: #163

Currently scalac-scoverage-plugin runs after typer and before patmat phases. There are no other phases in between so the order is unique and fixed.

Situation changes when using other scalac plugins which add phases in between typer and patmat. Scoverage phase can be then nondeterministically inserted somewhere between these new phases.

To fine-tune phases ordering I propose adding following flags

-P:scoverage:extraAfterPhase:<phaseName>
-P:scoverage:extraBeforePhase:<phaseName>

which would specify what other phases beside typer and patmat need to taken into account when determining phase ordering by appending them to runsAfter and runsBefore lists.

@sksamuel sksamuel merged commit 303534f into scoverage:master Jun 1, 2016
@sksamuel
Copy link
Member

sksamuel commented Jun 1, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants