Allow replacing stylesheet to preserve the cascade #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually this library will append media queries in separate <style> elements. However, doing this changes the cascade such that a media rule will be used over a non-media rule. This is because the media rule is removed from its position and appended after everything else. It is a common case that a non-media rule will override a media rule, so this inversion of the cascade makes it very difficult to style for all browsers using this polyfill. Turn on this option by setting `window.RESPOND_REPLACE_STYLES = true` before sourcing this script. It will remove every stylesheet it finds and move all CSS into the `media="all"` stylesheet that is appended, minus the inactive media query rules and those of other media types, like print. The other types are appended in the usual manner.
Bug was introduced when DRYing code to the `insertCss` function.
As a result of rebasing the `RESPOND_REPLACE_STYLES` option code onto 1c8ce14 (after previously being on 1.4.2), the replace index was being calculated as -1, meaning the query could not be found in the total styles. This was because comments are now being stripped. To fix that, the stripping of comments and keyframes from styles are done immediately in the `translate` function, and then stored with their replaced urls if `RESPOND_REPLACE_STYLES === true`.
Allow replacing stylesheet to preserve the cascade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scottjehl What do you think? I'm currently using it on a project and it ensures we can style for mobile first (min-width all the way) and not have to worry about IE8 looking like a really narrow mobile screen.
This fixes #325