Support media queries with widths expressed in rem. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rem to the regular expressions for width-based media queries. This was already discussed in scottjehl#18 but not implemented as part of this change.
|
Is there any reason this is not merged? I tested it and it works fine. This would also solve scenarios that https://github.com/chuckcarpenter/REM-unit-polyfill does not support today. |
|
Actually it look like REM-unit-polyfill has open issues and does not play nice with Respondjs. The solution you provided in this pull request will not function completely. For full REM support, please look into this solution: https://github.com/nbouvrette/remPolyfill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rem to the regular expressions for width-based media queries. This
was already discussed in #18 but not implemented as part of this change.
Tested with IE8 where this works as expected.