refactor: ship depreated things in a separate file #870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
force-pushed
the
refactor/separate-deprecations
branch
from
ad0a6fe to
2ac6ca9
Compare
|
Completed the "load eagerly (additionally) from in-tree bash_completion.d dir for in-tree setups" TODO item, I think we could merge this with the features present now, and address the remaining TODOs in separate PR's as suggested in #886 (comment) |
Primarily for run-in-place-from-git-clone setups.
scop
force-pushed
the
refactor/separate-deprecations
branch
from
2ac6ca9 to
cdd8a15
Compare
akinomyoga
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
Thank you for processing #870. I'd pre-approve it except for the style comment below:
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
This was referenced Feb 25, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Feb 26, 2023
akinomyoga
added a commit
to akinomyoga/bash-completion
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at #537 (reply in thread)
Draft/TODO:
@deprecatedcomments -> Mark which version something was deprecated in #893_comp_deprecate_functo specify the "deprecated in" bash-completion version (could use this in warning messages if we ever start to emit them) -> Mark which version something was deprecated in #893completions/*-> Move deprecated things incompletions/*to separate files #894