ci: Make distcheck not cancel jobs once one fails #1378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
reviewed
May 7, 2025
scop
approved these changes
May 10, 2025
There was a problem hiding this comment.
Yes, this is good, as long as it doesn't cause the matrix to succeed in case any of its entries fail. I think it doesn't, but the linked docs don't seem quite clear on it on a quick read.
We may want to say this disables the fail-fast option in the commit message rather than enables though.
It's pretty common that a specific distro fails the check, and since it currently cancels the rest of the matrix, you have to fix it first before seeing failures in other distros. This disables the fail-fast option: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
Just looking at the checks of this PR, some checks succeeded but still the CI is marked as failed.
Nice catch, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty common that a specific distro fails the check, and since it currently cancels the rest of the matrix, you have to fix it first before seeing failures in other distros.
This enables the fail-fast option:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast