refactor(psql): use exit status of _comp_compgen_split

akinomyoga · akinomyoga · commit 11dfd386facd · 2023-10-04T06:36:56.000+09:00
diff --git a/completions/psql b/completions/psql
@@ -12,8 +12,8 @@ _comp_cmd_psql__users()
 {
     # -w was introduced in 8.4, https://launchpad.net/bugs/164772
     _comp_compgen_split -- "$(psql -XAtqwc 'select usename from pg_user' \
-        template1 2>/dev/null)"
-    ((${#COMPREPLY[@]} == 0)) && _comp_compgen -- -u
+        template1 2>/dev/null)" ||
+        _comp_compgen -- -u
 }
 
 # createdb(1) completion

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,8 @@ _comp_cmd_psql__users()`
`12`	`12`	`{`
`13`	`13`	`# -w was introduced in 8.4, https://launchpad.net/bugs/164772`
`14`	`14`	`_comp_compgen_split -- "$(psql -XAtqwc 'select usename from pg_user' \`
`15`		`- template1 2>/dev/null)"`
`16`		`- ((${#COMPREPLY[@]} == 0)) && _comp_compgen -- -u`
	`15`	`+ template1 2>/dev/null)" \|\|`
	`16`	`+ _comp_compgen -- -u`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`# createdb(1) completion`